[PATCH] D62678: [ARM] Add MVE vector instructions that take a scalar input.

Simon Tatham via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 21 05:35:57 PDT 2019


simon_tatham updated this revision to Diff 205979.
simon_tatham added a comment.

Revised the `VIDUP` immediate operand handling so as to draw a distinction between the general concept 'power of 2 which is encoded as a left-shift count in the instruction', and the specific case used in VIDUP which takes a fixed range of inputs and has a custom DiagnosticString as you suggested that explains what it's used for.

Also, while I was adding custom DiagnosticStrings, I realised there could usefully be one on the even- and odd-numbered GPR classes. So I've added those too, which meant changing a couple of existing test files.

Finally, fixed those `bits<5> Rx` fields, and a couple of others I spotted in a more thorough search (including one in the previous patch, ahem).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62678/new/

https://reviews.llvm.org/D62678

Files:
  llvm/lib/Target/ARM/ARMInstrInfo.td
  llvm/lib/Target/ARM/ARMInstrMVE.td
  llvm/lib/Target/ARM/ARMRegisterInfo.td
  llvm/lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  llvm/lib/Target/ARM/Disassembler/ARMDisassembler.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
  llvm/test/MC/ARM/mve-qdest-rsrc.s
  llvm/test/MC/ARM/mve-reductions.s
  llvm/test/MC/ARM/mve-scalar-shift.s
  llvm/test/MC/Disassembler/ARM/mve-qdest-rsrc.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62678.205979.patch
Type: text/x-patch
Size: 70601 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190621/619029c0/attachment-0001.bin>


More information about the llvm-commits mailing list