[PATCH] D62678: [ARM] Add MVE vector instructions that take a scalar input.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2670
+  bits<4> Qn;
+  bits<5> Rm;
+
----------------
Rm should be 4 bits.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2697
+  bits<4> Qd;
+  bits<5> Rm;
+
----------------
Rm should be 4 bits.


================
Comment at: llvm/test/MC/ARM/mve-qdest-rsrc.s:483
+
+# ERROR: [[@LINE+1]]:{{[0-9]+}}: {{error|note}}: invalid operand for instruction
+viwdup.u32 q6, r10, r5, #3
----------------
Maybe not one for this patch, but you shoyld be able to add a DiagnosticString to the RegisterClass to get a better diagnostic here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62678/new/

https://reviews.llvm.org/D62678