[PATCH] D58736: [System Model] Introduce a target system model
David Greene via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 10:06:02 PDT 2019
greened marked an inline comment as done.
greened added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/BasicTTIImpl.h:523
+
+ // \return The cache line size in bytes.
+ virtual unsigned getCacheLineSize() const {
----------------
arsenm wrote:
> All of these should probably have address space arguments
What would the address space argument specify? What are the use-cases for modeling caches with address spaces? Perhaps this could replace the `resolve...` APIs. That would be nice.
These are existing interfaces so what would be the best way to transition them?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D58736/new/
https://reviews.llvm.org/D58736
More information about the llvm-commits
mailing list