[PATCH] D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol

Thu Jun 20 08:54:00 PDT 2019

MaskRay requested changes to this revision.
MaskRay added a comment.
This revision now requires changes to proceed.

Sorry for doing this. It is very late in my timezone, but I think I have to mark it as "Request Changes" as I saw it accepted and I really don't want it to be committed...

If you all agree `bar2 at plt-0x20` is less ideal and our `.plt` is better, I'm not sure why you want to copy the behavior of GNU objdump. I believe this belongs to the aesthetical area where 100% compatibility is not necessary. Programs/shell scripts parsing `<bar at plt-0x20>` should be extremely brittle and they should be avoided. If the programs need addresses, they should just parse the address part, not the stuff in angle quotes.

I have found someone who agrees with me that firstsym-x is awful and the behavior should not be replicated. Let me check if I can get more opinions tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63280/new/

https://reviews.llvm.org/D63280