[PATCH] D63280: [llvm-objdump] Use <first-symbol>-<offset> as the section start symbol
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 02:09:42 PDT 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
Okay, LGTM, but @MaskRay probably should confirm he's happy enough for now (we can improve the STT_SECTION bit later, if we want).
================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:348
+// Returns true if the section should be in disassemble output.
+static bool shouldKeepForDisassembly(object::SectionRef S) {
----------------
disassemble -> disassembly
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63280/new/
https://reviews.llvm.org/D63280
More information about the llvm-commits
mailing list