[PATCH] D63494: [AMDGPU] Fix for branch offset hardware workaround
Ryan Taylor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 05:48:55 PDT 2019
rtaylor marked an inline comment as done.
rtaylor added inline comments.
================
Comment at: lib/Target/AMDGPU/SOPInstructions.td:974
+ def "" : SOPP<op, ins, asm, pattern>;
+ def _PAD_S_NOP : SOPP64<op, ins, asm, pattern>;
+}
----------------
rampitec wrote:
> Can yo use InstrMapping mapping here to avoid switches?
Do you feel that this is worth it in this case? Seems overly complicated for a very specific use case but if it's the standard to go in this direction than ok.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63494/new/
https://reviews.llvm.org/D63494
More information about the llvm-commits
mailing list