[PATCH] D63543: [MCA][Bottleneck Analysis] Teach how to compute a critical sequence of instructions based on the simulation.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D63543#1551419 <https://reviews.llvm.org/D63543#1551419>, @mattd wrote:

> Awesome patch. I'm cool with this as long as Simon's comments are addressed.


Thanks Matt for the review.

I will soon send an updated patch that addresses Simon's comments.
I plan to wait for a few days to give more time to review the patch and  collect extra feedback (in case).

I forgot to mention in the summary that this patch doesn't include an llvm-documentation change.
The new bottleneck analysis probably requires its own sub-section in the llvm-mca documentation.

If reviewers are okay with it, I can do the documentation change in a follow-up patch.
In the meantime, if people want, I can raise a bug to add the bottleneck analysis description in the docs.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63543/new/

https://reviews.llvm.org/D63543