[PATCH] D63543: [MCA][Bottleneck Analysis] Teach how to compute a critical sequence of instructions based on the simulation.
Matt Davis via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 19 22:03:19 PDT 2019
mattd accepted this revision.
mattd added a comment.
This revision is now accepted and ready to land.
Awesome patch. I'm cool with this as long as Simon's comments are addressed.
================
Comment at: tools/llvm-mca/Views/BottleneckAnalysis.cpp:174
+ SmallVectorImpl<unsigned> &RootSet) const {
+ for (unsigned I = 0, E = Nodes.size(); I < E; ++I) {
+ const DGNode &N = Nodes[I];
----------------
Suggestion:
```
for (unsigned I : llvm::seq<unsigned>(0, Nodes.size())) {...}
```
================
Comment at: tools/llvm-mca/Views/BottleneckAnalysis.cpp:312
+ assert(Dep.Type == DependencyEdge::DT_RESOURCE &&
+ "Unexpected unsupported dependency type!");
+ FOS << "## RESOURCE interference: ";
----------------
Perhaps just "Unsupported dependency type!" Is there a case where we have an expected unsupported dependency type? If so then ignore my suggestion :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63543/new/
https://reviews.llvm.org/D63543
More information about the llvm-commits
mailing list