[PATCH] D63588: [llvm-nm] Generalize symbol types 'N' and 'n'

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM (assuming the output is consistent with GNU nm).



================
Comment at: tools/llvm-nm/llvm-nm.cpp:915
-    if (!Name) {
-      consumeError(Name.takeError());
       return '?';
----------------
MaskRay wrote:
> MaskRay wrote:
> > grimar wrote:
> > > Shouldn't the new code fail with LLVM_ENABLE_ABI_BREAKING_CHECKS because of removing this line?
> > llvm::object::SectionRef::getName(StringRef) still returns `error_code`... ( it has 95 references so i didn't fix it to use Error instead)
> Oh sorry, it should be `Expected<StringRef>`. Anyway, I haven't started the refactoring yet..
Ah, I see.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63588/new/

https://reviews.llvm.org/D63588