[PATCH] D63588: [llvm-nm] Generalize symbol types 'N' and 'n'
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 20 00:51:28 PDT 2019
MaskRay marked an inline comment as done.
MaskRay added inline comments.
================
Comment at: tools/llvm-nm/llvm-nm.cpp:915
- if (!Name) {
- consumeError(Name.takeError());
return '?';
----------------
MaskRay wrote:
> grimar wrote:
> > Shouldn't the new code fail with LLVM_ENABLE_ABI_BREAKING_CHECKS because of removing this line?
> llvm::object::SectionRef::getName(StringRef) still returns `error_code`... ( it has 95 references so i didn't fix it to use Error instead)
Oh sorry, it should be `Expected<StringRef>`. Anyway, I haven't started the refactoring yet..
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63588/new/
https://reviews.llvm.org/D63588
More information about the llvm-commits
mailing list