[llvm] r363780 - Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)

[Sjoerd Meijer via llvm-commits]

Again, sorry about this.
I've just put this up for review: https://reviews.llvm.org/D63569

Cheers,
Sjoerd
________________________________
From: Hans Wennborg <hans at chromium.org>
Sent: 19 June 2019 19:12
To: Jordan Rupprecht; Sjoerd Meijer
Cc: llvm-commits
Subject: Re: [llvm] r363780 - Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)

Seems fine to me, but Sjoerd also said on the bug that he's rewriting
the test to be more sane.

On Wed, Jun 19, 2019 at 8:04 PM Jordan Rupprecht via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
>
> I saw this test timeout internally (not sure how, it doesn't seem _that_ slow), so I committed r363851 as a different fix which I think should also suffice for the memory growth issue -- but I don't have a 32-bit machine to verify on, so PTAL.
>
> On Wed, Jun 19, 2019 at 2:43 AM Hans Wennborg via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>
>> Author: hans
>> Date: Wed Jun 19 02:46:37 2019
>> New Revision: 363780
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=363780&view=rev
>> Log:
>> Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)
>>
>> The test still probably shouldn't run this loop 17 million times, but at
>> least now it won't run out of memory.
>>
>> Modified:
>>     llvm/trunk/unittests/Support/TargetParserTest.cpp
>>
>> Modified: llvm/trunk/unittests/Support/TargetParserTest.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/TargetParserTest.cpp?rev=363780&r1=363779&r2=363780&view=diff
>> ==============================================================================
>> --- llvm/trunk/unittests/Support/TargetParserTest.cpp (original)
>> +++ llvm/trunk/unittests/Support/TargetParserTest.cpp Wed Jun 19 02:46:37 2019
>> @@ -569,15 +569,16 @@ TEST(TargetParserTest, ARMFPURestriction
>>  }
>>
>>  TEST(TargetParserTest, ARMExtensionFeatures) {
>> -  std::vector<StringRef> Features;
>>    unsigned Extensions = ARM::AEK_CRC | ARM::AEK_CRYPTO | ARM::AEK_DSP |
>>                          ARM::AEK_HWDIVARM | ARM::AEK_HWDIVTHUMB | ARM::AEK_MP |
>>                          ARM::AEK_SEC | ARM::AEK_VIRT | ARM::AEK_RAS | ARM::AEK_FP16 |
>>                          ARM::AEK_FP16FML | ARM::AEK_FP_DP;
>>
>> -  for (unsigned i = 0; i <= Extensions; i++)
>> +  for (unsigned i = 0; i <= Extensions; i++) {
>> +    std::vector<StringRef> Features;
>>      EXPECT_TRUE(i == 0 ? !ARM::getExtensionFeatures(i, Features)
>>                         : ARM::getExtensionFeatures(i, Features));
>> +  }
>>  }
>>
>>  TEST(TargetParserTest, ARMFPUFeatures) {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190619/bfd2e01a/attachment.html>