<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Again, sorry about this.</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
I've just put this up for review: <a href="https://reviews.llvm.org/D63569" id="LPlnk947826">https://reviews.llvm.org/D63569</a></div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Cheers,</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Sjoerd</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Hans Wennborg <hans@chromium.org><br>
<b>Sent:</b> 19 June 2019 19:12<br>
<b>To:</b> Jordan Rupprecht; Sjoerd Meijer<br>
<b>Cc:</b> llvm-commits<br>
<b>Subject:</b> Re: [llvm] r363780 - Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">Seems fine to me, but Sjoerd also said on the bug that he's rewriting<br>
the test to be more sane.<br>
<br>
On Wed, Jun 19, 2019 at 8:04 PM Jordan Rupprecht via llvm-commits<br>
<llvm-commits@lists.llvm.org> wrote:<br>
><br>
> I saw this test timeout internally (not sure how, it doesn't seem _that_ slow), so I committed r363851 as a different fix which I think should also suffice for the memory growth issue -- but I don't have a 32-bit machine to verify on, so PTAL.<br>
><br>
> On Wed, Jun 19, 2019 at 2:43 AM Hans Wennborg via llvm-commits <llvm-commits@lists.llvm.org> wrote:<br>
>><br>
>> Author: hans<br>
>> Date: Wed Jun 19 02:46:37 2019<br>
>> New Revision: 363780<br>
>><br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=363780&view=rev">http://llvm.org/viewvc/llvm-project?rev=363780&view=rev</a><br>
>> Log:<br>
>> Make TargetParserTest.ARMExtensionFeatures not run out of memory on 32-bit (PR42316)<br>
>><br>
>> The test still probably shouldn't run this loop 17 million times, but at<br>
>> least now it won't run out of memory.<br>
>><br>
>> Modified:<br>
>> llvm/trunk/unittests/Support/TargetParserTest.cpp<br>
>><br>
>> Modified: llvm/trunk/unittests/Support/TargetParserTest.cpp<br>
>> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/TargetParserTest.cpp?rev=363780&r1=363779&r2=363780&view=diff">
http://llvm.org/viewvc/llvm-project/llvm/trunk/unittests/Support/TargetParserTest.cpp?rev=363780&r1=363779&r2=363780&view=diff</a><br>
>> ==============================================================================<br>
>> --- llvm/trunk/unittests/Support/TargetParserTest.cpp (original)<br>
>> +++ llvm/trunk/unittests/Support/TargetParserTest.cpp Wed Jun 19 02:46:37 2019<br>
>> @@ -569,15 +569,16 @@ TEST(TargetParserTest, ARMFPURestriction<br>
>> }<br>
>><br>
>> TEST(TargetParserTest, ARMExtensionFeatures) {<br>
>> - std::vector<StringRef> Features;<br>
>> unsigned Extensions = ARM::AEK_CRC | ARM::AEK_CRYPTO | ARM::AEK_DSP |<br>
>> ARM::AEK_HWDIVARM | ARM::AEK_HWDIVTHUMB | ARM::AEK_MP |<br>
>> ARM::AEK_SEC | ARM::AEK_VIRT | ARM::AEK_RAS | ARM::AEK_FP16 |<br>
>> ARM::AEK_FP16FML | ARM::AEK_FP_DP;<br>
>><br>
>> - for (unsigned i = 0; i <= Extensions; i++)<br>
>> + for (unsigned i = 0; i <= Extensions; i++) {<br>
>> + std::vector<StringRef> Features;<br>
>> EXPECT_TRUE(i == 0 ? !ARM::getExtensionFeatures(i, Features)<br>
>> : ARM::getExtensionFeatures(i, Features));<br>
>> + }<br>
>> }<br>
>><br>
>> TEST(TargetParserTest, ARMFPUFeatures) {<br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> llvm-commits@lists.llvm.org<br>
>> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> llvm-commits@lists.llvm.org<br>
> <a href="https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits">https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits</a><br>
</div>
</span></font></div>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose,
or store or copy the information in any medium. Thank you.
</body>
</html>