[PATCH] D63494: [AMDGPU] Fix for branch offset hardware workaround

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 19 11:52:04 PDT 2019


arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/MCTargetDesc/AMDGPUAsmBackend.cpp:61
+  case AMDGPU::S_BRANCH:
+    return AMDGPU::S_BRANCH_PAD_S_NOP;
+  case AMDGPU::S_CBRANCH_SCC0:
----------------
I would lowercase the suffix. The general naming convention its HARDWARE_NAME_compiler_defined_variant


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63494/new/

https://reviews.llvm.org/D63494





More information about the llvm-commits mailing list