[PATCH] D63489: [InstSimplify] LCSSA PHIs should not be simplified away

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

Also, this code change causes lots of existing middle-end test failures, so it doesn't appear to be some harmless/degenerate pattern:

Failing Tests (43):

  LLVM :: Transforms/CodeGenPrepare/X86/computedgoto.ll
  LLVM :: Transforms/Coroutines/ArgAddr.ll
  LLVM :: Transforms/CorrelatedValuePropagation/select.ll
  LLVM :: Transforms/GlobalDCE/complex-constantexpr.ll
  LLVM :: Transforms/IndVarSimplify/rewrite-loop-exit-value.ll
  LLVM :: Transforms/Inline/AArch64/phi.ll
  LLVM :: Transforms/Inline/bfi-update.ll
  LLVM :: Transforms/Inline/inline-fast-math-flags.ll
  LLVM :: Transforms/Inline/inline_constprop.ll
  LLVM :: Transforms/InstCombine/gep-combine-loop-invariant.ll
  LLVM :: Transforms/InstCombine/gepphigep.ll
  LLVM :: Transforms/InstMerge/st_sink_bugfix_22613.ll
  LLVM :: Transforms/InstSimplify/phi.ll
  LLVM :: Transforms/LICM/2003-05-02-LoadHoist.ll
  LLVM :: Transforms/LoopInstSimplify/basic.ll
  LLVM :: Transforms/LoopSimplify/ashr-crash.ll
  LLVM :: Transforms/LoopSimplify/merge-exits.ll
  LLVM :: Transforms/LoopUnroll/runtime-loop-multiple-exits.ll
  LLVM :: Transforms/LoopUnroll/runtime-loop4.ll
  LLVM :: Transforms/LoopUnroll/runtime-multiexit-heuristic.ll
  LLVM :: Transforms/LoopUnroll/runtime-unroll-remainder.ll
  LLVM :: Transforms/LoopUnroll/unroll-cleanup.ll
  LLVM :: Transforms/LoopUnswitch/2007-07-12-ExitDomInfo.ll
  LLVM :: Transforms/LoopUnswitch/unswitch-equality-undef.ll
  LLVM :: Transforms/LoopVectorize/AMDGPU/packed-math.ll
  LLVM :: Transforms/LoopVectorize/X86/already-vectorized.ll
  LLVM :: Transforms/LoopVectorize/X86/float-induction-x86.ll
  LLVM :: Transforms/LoopVectorize/X86/reg-usage.ll
  LLVM :: Transforms/LoopVectorize/X86/small-size.ll
  LLVM :: Transforms/LoopVectorize/X86/unroll-pm.ll
  LLVM :: Transforms/LoopVectorize/first-order-recurrence.ll
  LLVM :: Transforms/LoopVectorize/gcc-examples.ll
  LLVM :: Transforms/LoopVectorize/if-conversion.ll
  LLVM :: Transforms/LoopVectorize/opt.ll
  LLVM :: Transforms/LoopVectorize/read-only.ll
  LLVM :: Transforms/LoopVectorize/reduction.ll
  LLVM :: Transforms/LoopVectorize/value-ptr-bug.ll
  LLVM :: Transforms/LoopVectorize/vectorize-once.ll
  LLVM :: Transforms/PhaseOrdering/reassociate-after-unroll.ll
  LLVM :: Transforms/PhaseOrdering/simplifycfg-options.ll
  LLVM :: Transforms/SimpleLoopUnswitch/2007-07-12-ExitDomInfo.ll
  LLVM :: Transforms/SimpleLoopUnswitch/update-scev.ll
  LLVM :: Transforms/ThinLTOBitcodeWriter/no-type-md.ll


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63489/new/

https://reviews.llvm.org/D63489