[PATCH] D57792: [RISCV] Support z and i operand modifiers

Tue Jun 18 22:31:27 PDT 2019

jrtc27 added a comment.

In D57792#1549678 <https://reviews.llvm.org/D57792#1549678>, @asb wrote:

> In D57792#1549676 <https://reviews.llvm.org/D57792#1549676>, @jrtc27 wrote:
>
> > In D57792#1549669 <https://reviews.llvm.org/D57792#1549669>, @asb wrote:
> >
> > > Is there documentation on the operand modifiers supported by RISC-V binutils anywhere? I'm struggling to find anything...
> >
> >
> > This is GCC not binutils, and I can't find them documented anywhere other than the source itself: https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/riscv/riscv.c?view=markup&revision=271293#l3181
>
>
> Sorry, I meant GCC.
>
> Thanks, this patch looks good to me. Tiny nit: LLVM coding guidelines prefer full sentences for comments, so the comments added to RISCVAsmPrinter.cpp should end in a full stop.

Blame the Mips backend for leading me astray for this function...

> EDIT: You'll want to add nounwind attributes to the functions in your test too.

Yes, just went to check that between your initial commenting and edit.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57792/new/

https://reviews.llvm.org/D57792