[PATCH] D57792: [RISCV] Support z and i operand modifiers

Tue Jun 18 22:24:14 PDT 2019

asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

In D57792#1549676 <https://reviews.llvm.org/D57792#1549676>, @jrtc27 wrote:

> In D57792#1549669 <https://reviews.llvm.org/D57792#1549669>, @asb wrote:
>
> > Is there documentation on the operand modifiers supported by RISC-V binutils anywhere? I'm struggling to find anything...
>
>
> This is GCC not binutils, and I can't find them documented anywhere other than the source itself: https://gcc.gnu.org/viewcvs/gcc/trunk/gcc/config/riscv/riscv.c?view=markup&revision=271293#l3181

Sorry, I meant GCC.

Thanks, this patch looks good to me. Tiny nit: LLVM coding guidelines prefer full sentences for comments, so the comments added to RISCVAsmPrinter.cpp should end in a full stop.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D57792/new/

https://reviews.llvm.org/D57792