[PATCH] D63239: [llvm-objcopy][NFC] Refactor output target parsing

[Jordan Rupprecht via Phabricator via llvm-commits]

rupprecht accepted this revision.
rupprecht marked an inline comment as done.
rupprecht added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:471
+
+  // FIXME: Here we ignores the target explicitly specified by -I option (e.g.
+  // -Ielf32-x86-64).
----------------
jhenderson wrote:
> ignores -> ignore
> 
> I'm not really sure what this is trying to point out though. Is it an existing bug in llvm-objcopy or one you are introducing?
It's an existing bug; we handle "-I binary" and "-I ihex", but specifying "-Ielf32..." is the same as not specifying it at all.

Maybe a clearer message would be "ignore the target for non-binary/ihex formats"


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63239/new/

https://reviews.llvm.org/D63239