[PATCH] D63239: [llvm-objcopy][NFC] Refactor output target parsing

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 18 03:19:54 PDT 2019


jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:471
+
+  // FIXME: Here we ignores the target explicitly specified by -I option (e.g.
+  // -Ielf32-x86-64).
----------------
ignores -> ignore

I'm not really sure what this is trying to point out though. Is it an existing bug in llvm-objcopy or one you are introducing?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63239/new/

https://reviews.llvm.org/D63239





More information about the llvm-commits mailing list