[PATCH] D63432: [ELF] Allow placing SHF_MERGE sections with different alignments into the same MergeSyntheticSection

Tue Jun 18 02:05:45 PDT 2019

peter.smith added a comment.

A small nit in the test, but otherwise looks good to me.

================
Comment at: test/ELF/merge-reloc-entsize.s:13
+
+# HEX-NEXT: Hex dump of section '.cst':
+# HEX-NEXT: 0x00000000 01000000 00000000 02000000
----------------
These appear to be unused. I think readelf -x .cst may not be the best here as it only outputs the first, and includes file padding for alignment. Perhaps llvm-objdump -s which gives:

```
Contents of section .cst:
 0000 01000000 00000000 02000000
Contents of section .cst:
 0000 01000000 00000000 03000000 00000000
```

Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63432/new/

https://reviews.llvm.org/D63432