[PATCH] D63432: [ELF] Allow placing SHF_MERGE sections with different alignments into the same MergeSyntheticSection

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 17 22:36:19 PDT 2019


MaskRay added a comment.

@nickdesaulniers I think this change is still worth making no matter if the Linux kernel use case is a bug or not.

Suppose `sh_name,sh_flags,sh_entsize` are all the same, for two sections with different `sh_addralign`, we currently don't combine them. However, I can't find anything that disallows the merge. The `-r` result will eventually be used as a `-no-pie/-pie/-shared` link, this patch allows us to merge potentially more strings.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63432/new/

https://reviews.llvm.org/D63432





More information about the llvm-commits mailing list