[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:61
+    : AST(AST) {
+  if (Fmt.Valid)
+    this->Fmt = Fmt;
----------------
`this->Fmt = Fmt.Valid ? Fmt : FmtUnsigned;`


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:99
 TEST_F(FileCheckTest, Binop) {
-  auto FooVar = std::make_shared<FileCheckNumericVariable>(1, "FOO", nullptr);
+  auto DefNumExpr = FileCheckNumExpr(nullptr, FmtUnsigned);
+  auto FooVar =
----------------
`FileCheckNumExpr DefNumExpr(..)` or `FileCheckNumExpr DefNumExpr{..}`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389