[PATCH] D60389: FileCheck [9/12]: Add support for matching formats

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/lib/Support/FileCheck.cpp:357
+    Expr = Expr.ltrim(SpaceChars);
+    if (stripFront(Expr, "%", false /*Optional*/))
+      return FileCheckParseError::get(
----------------
`/*Optional*/` is usually written before the argument:

`/*Optional=*/false`


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:74
+  auto FoobarExpr = FileCheckNumExpr(Binop, FmtUnsigned);
   FileCheckNumericVariable FoobarVar =
+      FileCheckNumericVariable(2, "FOOBAR", &FoobarExpr);
----------------
`FileCheckNumericVariable FoobarVar(...)` or `FileCheckNumericVariable FoobarVar{...}`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60389/new/

https://reviews.llvm.org/D60389