[PATCH] D60974: Clang IFSO driver action.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:22
+  StringRef Format;
+  std::set<std::string> ParsedTemplates;
+
----------------
Does `StringSet<>` work?


================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:36
+  };
+  using MangledSymbols = std::map<const NamedDecl *, MangledSymbol>;
+
----------------
Are you relying on the ordered property of `std::map`?


================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:101
+      return true;
+    if (Symbols.find(ND) != Symbols.end())
+      return true;
----------------
`.count`


================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:103
+      return true;
+    // - Currently have not figured out how to produce the names for FieldDecls.
+    // - Do not want to produce symbols for function paremeters.
----------------
This should be a TODO


================
Comment at: cfe/trunk/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:124
+
+      Symbols.insert(std::make_pair(
+          ND,
----------------
If you use a llvm container, `emplace` or `try_emplace`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974