[PATCH] D60974: Clang IFSO driver action.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: cfe/trunk/lib/Frontend/CMakeLists.txt:58
   clangDriver
+  clangIndex
   clangEdit
----------------
This is a layering issue. clangIndex depends on clangFrontend so clangFrontend should not depend on clangIndex.

The circular dependency is allowed for static libraries but it breaks `-DBUILD_SHARED_LIBS=on`:

```
CMake Error: The inter-target dependency graph contains the following strongly connected component (cycle):    
  "clangFrontend" of type SHARED_LIBRARY
    depends on "clangIndex" (weak)
  "clangIndex" of type SHARED_LIBRARY
    depends on "clangFrontend" (weak)
At least one of these targets is not a STATIC_LIBRARY.  Cyclic dependencies are allowed only among static libraries.
```


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60974/new/

https://reviews.llvm.org/D60974