[PATCH] D62964: [llvm-objdump] Include dynamic zero-sized and non-function symbols in disassembly

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/test/tools/llvm-objdump/X86/elf-disassemble-dynamic-symbols.test:124
+    Size:    1
+    Type:    STT_LOOS
+    Binding: STB_GLOBAL
----------------
As noted in D63393, we shouldn't do this and should instead use 0x10 or whatever explicitly, since STT_LOOS etc are just range markers. Also, it's probably only necessary to test one value in each range.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62964/new/

https://reviews.llvm.org/D62964