[PATCH] D63236: [mips] Add empty scheduler info and `NoItinerary` to the `MipsAsmPseudoInst`

[Simon Atanasyan via Phabricator via llvm-commits]

atanasyan marked an inline comment as done.
atanasyan added inline comments.


================
Comment at: llvm/lib/Target/Mips/MipsInstrFormats.td:146
 class MipsAsmPseudoInst<dag outs, dag ins, string asmstr>:
-  MipsInst<outs, ins, asmstr, [], IIPseudo, Pseudo> {
+  MipsInst<outs, ins, asmstr, [], NoItinerary, Pseudo>, Sched<[]> {
   let isPseudo = 1;
----------------
Petar.Avramovic wrote:
> I looked only at `CodeGenSchedModels::checkCompleteness()`
> We already have few pseudos with `let hasNoSchedulingInfo = 1;` and this has same effect (no error) in `checkCompleteness` as `NoItinerary` + empty `Sched`. Are there any advantages in using the latter?
> 
Good point. The hasNoSchedulingInfo is enough. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63236/new/

https://reviews.llvm.org/D63236