[PATCH] D63236: [mips] Add empty scheduler info and `NoItinerary` to the `MipsAsmPseudoInst`

Petar Avramovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 13 04:56:35 PDT 2019


Petar.Avramovic added inline comments.


================
Comment at: llvm/lib/Target/Mips/MipsInstrFormats.td:146
 class MipsAsmPseudoInst<dag outs, dag ins, string asmstr>:
-  MipsInst<outs, ins, asmstr, [], IIPseudo, Pseudo> {
+  MipsInst<outs, ins, asmstr, [], NoItinerary, Pseudo>, Sched<[]> {
   let isPseudo = 1;
----------------
I looked only at `CodeGenSchedModels::checkCompleteness()`
We already have few pseudos with `let hasNoSchedulingInfo = 1;` and this has same effect (no error) in `checkCompleteness` as `NoItinerary` + empty `Sched`. Are there any advantages in using the latter?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63236/new/

https://reviews.llvm.org/D63236





More information about the llvm-commits mailing list