[PATCH] D63109: lld-link: Reject more than one resource .obj file

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 16 12:12:33 PDT 2019


mstorsjo added a comment.

FWIW, I ran into one error with this on VLC. In one case, a static library ends up (erroneously) containing a resource object file. This static library is included with the `--whole-archive` option (indirectly, via lots of libtool magic) when linking a DLL, which also contains a resource object files of its own.

In that case, it's possible to fix the issue by removing the intermediate static library which seems to be pointless at the moment. But extending lld to ignore resource object files when linking with `--whole-archive` would probably be good.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63109/new/

https://reviews.llvm.org/D63109





More information about the llvm-commits mailing list