[PATCH] D63109: lld-link: Reject more than one resource .obj file

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 11 11:23:21 PDT 2019


mstorsjo added a comment.

> The only real way to run into this is if users manually convert .res files to .obj files by running cvtres and then handing the resulting .obj files to lld-link instead, which in practice likely never happens.

In MinGW land, GNU windres (and compatible drop-in replacements) default to converting the resource output data to object file form. But if you say this already produces invalid results with lld, I presume this is a good change as it makes it clearer instead of producing subtly broken files. Not sure if it's common for MinGW built projects to have multiple resource object files or not.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63109/new/

https://reviews.llvm.org/D63109





More information about the llvm-commits mailing list