[PATCH] D63300: AArch64: Prefer FP-relative debug locations in HWASANified functions.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc marked an inline comment as done.
pcc added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1538
+                                                     bool PreferFP,
+                                                     bool ForSimm) const {
   const auto &MFI = MF.getFrameInfo();
----------------
eugenis wrote:
> should this be called ForDebugInfo, or something like that? It's not about signed immediate IMHO, it's about debug info having effectively infinite offset range.
> 
I thought about giving it a name like that, but it seems like the restriction is specific to the operand on certain load and store instructions referred to as `<simm>`, or a 9-bit signed immediate. If we were producing an immediate for a different instruction, we would want this to be false.

That said, maybe it should be called something like `ForLdSt`, then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63300/new/

https://reviews.llvm.org/D63300