[PATCH] D63300: AArch64: Prefer FP-relative debug locations in HWASANified functions.
Evgenii Stepanov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jun 14 14:00:53 PDT 2019
eugenis added a comment.
In D63300#1543961 <https://reviews.llvm.org/D63300#1543961>, @eugenis wrote:
> What if we do it the other way around - store SP instead of FP? SP is unusable for locals when there are dynamic allocas; FP is unusable when there is dynamic stack realignment; not sure which case is more common, but both should be rare enough. This could help with the code size at least a little.
Right, good point.
================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1538
+ bool PreferFP,
+ bool ForSimm) const {
const auto &MFI = MF.getFrameInfo();
----------------
should this be called ForDebugInfo, or something like that? It's not about signed immediate IMHO, it's about debug info having effectively infinite offset range.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63300/new/
https://reviews.llvm.org/D63300
More information about the llvm-commits
mailing list