[llvm] r363317 - Revert "[NFC][CodeGen] Add unary fneg tests to fp-fast.ll fp-fold.ll fp-in-intregs.ll fp-stack-compare-cmov.ll fp-stack-compare.ll fsxor-alignment.ll"

Cameron McInally via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 14 08:16:57 PDT 2019


On Fri, Jun 14, 2019 at 10:23 AM Roman Lebedev <lebedev.ri at gmail.com> wrote:

> What happened with all those fneg test reverts, anyway?


Yeah, sorry about the noise. The original plan was to duplicate any test
that uses binary FNeg IR, to minimize regressions. It was later determined
that it's fairly easy to prove that CodeGen is unaffected by the unary FNeg
change since the first thing the SelectionDAGBuilder does in visitFSub(...)
is to convert binary FNeg IR into an ISD::FNeg.

Apologies again for the churn...

-Cam
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190614/942b1a9d/attachment.html>


More information about the llvm-commits mailing list