[PATCH] D63306: Add a remarks-based code size diffing tool

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere added inline comments.


================
Comment at: llvm/tools/sizediff/sizediff.cpp:53
+  // new file.
+  int Count[2] = {0, 0};
+
----------------
I would use two integers with descriptive names, unless you expect to extend this in the future? You could keep `collectRemarks` generic and pass an enum instead of the index as the second argument, and have a setter with a switch.


================
Comment at: llvm/tools/sizediff/sizediff.cpp:91
+    return make_error<StringError>(
+        "Currently, only Mach-O files are supported",
+        std::make_error_code(std::errc::invalid_argument));
----------------
What happens when you pass a fat binary?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63306/new/

https://reviews.llvm.org/D63306