[PATCH] D63306: Add a remarks-based code size diffing tool

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg added inline comments.


================
Comment at: llvm/test/tools/sizediff/basic-input.s:4
+// RUN: sed s!FILEPATH!%/p/Inputs/basic-b.opt.yaml! %s | llvm-mc -triple x86_64-apple-darwin --filetype=obj -o=%t2
+// RUN: sizediff %t1 %t2
+
----------------
`| FileCheck %s` ?


================
Comment at: llvm/tools/sizediff/sizediff.cpp:42
+namespace {
+bool HadError = false;
+std::string ToolName;
----------------
Maybe use `llvm::Error` and `llvm::Expected` instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63306/new/

https://reviews.llvm.org/D63306