[PATCH] D62670: [ARM] Add MVE horizontal accumulation instructions.

Thu Jun 13 05:52:07 PDT 2019

miyuki marked 2 inline comments as done.
miyuki added inline comments.

================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:421
+  : MVE_rDest<(outs tGPREven:$RdaDest),
+              !if(!eq(A, 1), (ins tGPREven:$RdaSrc, MQPR:$Qn, MQPR:$Qm),
+                             (ins MQPR:$Qn, MQPR:$Qm)),
----------------
ostannard wrote:
> Again, this is quite hard to follow, I think it would be better to move the operand lists down to the multiclass.
But this would mean duplicating everything (i.e., input operands and constraints) 4 times for each case. And 6 times for t2VMLALDAVBase. Wouldn't it be better to create separate subclasses for accumulating and non-accumulating versions?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62670/new/

https://reviews.llvm.org/D62670