[PATCH] D62670: [ARM] Add MVE horizontal accumulation instructions.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:272
+  : MVE_rDest<(outs tGPREven:$Rda),
+              !if(!eq(A, 1), (ins tGPREven:$Rda_src, MQPR:$Qm), (ins MQPR:$Qm)),
+              NoItinerary,
----------------
This class is only instantiated once with each value of A, so I think it would be clearer to make these parameters and move the values down to the multiclass below.


================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:421
+  : MVE_rDest<(outs tGPREven:$RdaDest),
+              !if(!eq(A, 1), (ins tGPREven:$RdaSrc, MQPR:$Qn, MQPR:$Qm),
+                             (ins MQPR:$Qn, MQPR:$Qm)),
----------------
Again, this is quite hard to follow, I think it would be better to move the operand lists down to the multiclass.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62670/new/

https://reviews.llvm.org/D62670