[PATCH] D62583: [llvm-objcopy] Implement IHEX reader

Wed Jun 12 15:27:55 PDT 2019

rupprecht accepted this revision.
rupprecht marked an inline comment as done.
rupprecht added a subscriber: seiya.
rupprecht added inline comments.
This revision is now accepted and ready to land.

================
Comment at: test/tools/llvm-objcopy/ELF/ihex-reader.test:4
+# RUN: llvm-objcopy -O ihex %t %t.hex
+# RUN: llvm-objcopy -I ihex %t.hex %t2
+# RUN: llvm-readobj -section-headers %t2 | FileCheck %s
----------------
rupprecht wrote:
> The output format here is unspecified, so it's not clear if we should convert this to elf32-i386, elf64-x86-64, any of the (unimplemented) macho/coff outputs, etc. We should either assume the output is also ihex (what GNU objcopy appears to do) or return some kind of warning/error (also seems reasonable if we don't need to match failure-ness for that situation -- I wonder if anyone relies on that working?)
> 
> I'm not sure if this problem is related to your patch though; running "llvm-objcopy -I binary -Barm foo.txt bar" also creates an object file when it shouldn't. For now, can you just put an explicit output format (probably you want -O elf64-x86-64)
@seiya is working on patch to fix this, btw

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62583/new/

https://reviews.llvm.org/D62583