[PATCH] D62583: [llvm-objcopy] Implement IHEX reader

Tue Jun 11 03:05:26 PDT 2019

evgeny777 added inline comments.

================
Comment at: test/tools/llvm-objcopy/ELF/ihex-reader.test:122
+# CHECK-NEXT:    Offset: 0x49
+# CHECK-NEXT:    Size: 11
+# CHECK-NEXT:    Link: 0
----------------
rupprecht wrote:
> Running the same scenario through GNU objcopy, there are a couple significant differences in the generated object file starting here -- looks like GNU objcopy gets confused and splits the "0123456789@" into separate sections, so size here is 8, and the next section is size 3 to handle the spill over... it looks like llvm-objcopy is correct here, but mind reviewing that to make sure llvm-objcopy is making sense here?
GNU objcopy always starts new section if it encounters SegmentAddr (02) or ExtendedAddr (04). There seems to be no strong reason doing so in llvm-objcopy, unless someone explicitly requests this.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62583/new/

https://reviews.llvm.org/D62583