[PATCH] D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure

[Amy Kwan via Phabricator via llvm-commits]

amyk added inline comments.


================
Comment at: llvm/lib/Target/SystemZ/SystemZMachineScheduler.cpp:83
+          "Saving scheduled state for MBB twice?");
+  assert(HazardRec && "HazardRec must be set when enter the MBB");
 
----------------
`when enter the MBB` -> `when entering the MBB`


================
Comment at: llvm/lib/Target/SystemZ/SystemZMachineScheduler.cpp:121
+    const MachineLoop *Loop = MLI->getLoopFor(CurrentMBB);
+    if (Loop && Loop->getHeader() == CurrentMBB) dbgs() << " (Loop header)";
+    dbgs() << ":\n";);
----------------
Should the `dbgs()` be on a new line?


================
Comment at: llvm/lib/Target/SystemZ/SystemZMachineScheduler.h:138
 
+  /// Tell the stragegy to save the scheduled state before leaving the MBB, so
+  /// that, its scheduled state could be forward to successor MBB.
----------------
`stragegy` -> `strategy`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61249/new/

https://reviews.llvm.org/D61249