[PATCH] D61249: [NFC] Refactor the systemZ scheduler strategy to adapt with the new schedule state forwarding infrastructure
Lei Huang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 12 07:44:01 PDT 2019
lei added inline comments.
================
Comment at: llvm/lib/Target/SystemZ/SystemZMachineScheduler.h:139
+ /// Tell the stragegy to save the scheduled state before leaving the MBB, so
+ /// that, its scheduled state could be forward to successor MBB.
+ bool saveScheduledState(MachineBasicBlock *MBB) override;
----------------
nit: `so that, its...` -> `so its scheduled state...`
================
Comment at: llvm/lib/Target/SystemZ/SystemZMachineScheduler.h:149
+ /// we are going from latch to the loop header most time, except the first
+ /// time.
+ MachineBasicBlock *getScheduledPredMBB(MachineBasicBlock *MBB) override;
----------------
I find this explanation some what confusing and it's also different from the function definition below.
Should it be something similar to what was doc below originally on line 37?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61249/new/
https://reviews.llvm.org/D61249
More information about the llvm-commits
mailing list