[PATCH] D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid

[James Henderson via Phabricator via llvm-commits]

jhenderson added inline comments.


================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1998
+      else
+        Libs.push_back("<library name not found>");
+    }
----------------
MaskRay wrote:
> I think `not found` is not entirely accurate. The issue is that the index into the string table is invalid (out of range). Do other reviewers have suggestion for the message used here?
You're probably right. It should probably be something like `<library name index out of range>` or `<library name index invalid>` like you suggest.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63084/new/

https://reviews.llvm.org/D63084