[PATCH] D63084: [llvm-readobj] Don't abort printing of dynamic table if string reference is invalid
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 12 01:59:56 PDT 2019
MaskRay added inline comments.
================
Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1998
+ else
+ Libs.push_back("<library name not found>");
+ }
----------------
I think `not found` is not entirely accurate. The issue is that the index into the string table is invalid (out of range). Do other reviewers have suggestion for the message used here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63084/new/
https://reviews.llvm.org/D63084
More information about the llvm-commits
mailing list