[PATCH] D63125: FileCheck: Return parse error w/ Error & Expected

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 12 02:13:58 PDT 2019


thopre updated this revision to Diff 204238.
thopre added a comment.

- Fix bugs in unit test when running with Error checks enabled
- Make eval() functions return an Expected instead of Optional
- Create helper functions to create ParseError and its associated diagnostic
- Rename ParseErrorInfo into FileCheckParseError


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63125/new/

https://reviews.llvm.org/D63125

Files:
  llvm/include/llvm/Support/FileCheck.h
  llvm/lib/Support/FileCheck.cpp
  llvm/test/FileCheck/string-defines-diagnostics.txt
  llvm/unittests/Support/FileCheckTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D63125.204238.patch
Type: text/x-patch
Size: 54580 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190612/7719a1ec/attachment-0001.bin>


More information about the llvm-commits mailing list