[PATCH] D63125: FileCheck: Return parse error w/ Error & Expected

[Alexander Richardson via Phabricator via llvm-commits]

arichardson added a comment.

Looks good to me. Just two minor comments:

This adds quite a lot of `return make_error<ParseErrorInfo>(SM.GetMessage(SMLoc::getFromPointer(Foo.data()), SourceMgr::DK_Error,  "...")));`
Maybe adding a helper would make sense? Something like:

  Error ParseErrorInfo::get(const SourceManager& SM, const char* LocPtr, const Twine& ErrMsg) {
     return make_error<ParseErrorInfo>(SM.GetMessage(SMLoc::getFromPointer(LocPtr), SourceMgr::DK_Error,  ErrMsg)));
  }

Then the above can just be `return ParseErrorInfo::get(SM, Foo.data(),  "...");`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63125/new/

https://reviews.llvm.org/D63125