[polly] r363121 - [ScopBuilder] Move hoistInvariantLoads to ScopBuilder. NFC.
Michael Kruse via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 11 21:23:06 PDT 2019
Author: meinersbur
Date: Tue Jun 11 21:23:05 2019
New Revision: 363121
URL: http://llvm.org/viewvc/llvm-project?rev=363121&view=rev
Log:
[ScopBuilder] Move hoistInvariantLoads to ScopBuilder. NFC.
Refactor Scop and ScopBuilder class:
1. Move hoistInvariantLoads function from Scop to ScopBuilder class.
2. Private functions (addInvariantLoads, getNonHoistableCtx) are moved
to public section of Scop class. hoistInvariantLoads function
references these functions. These functions will be moved to
ScopBuilder as well in the next steps.
Patch by Dominik Adamski <adamski.dominik at gmail.com>
Differential Revision: https://reviews.llvm.org/D62925
Modified:
polly/trunk/include/polly/ScopBuilder.h
polly/trunk/include/polly/ScopInfo.h
polly/trunk/lib/Analysis/ScopBuilder.cpp
polly/trunk/lib/Analysis/ScopInfo.cpp
Modified: polly/trunk/include/polly/ScopBuilder.h
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopBuilder.h?rev=363121&r1=363120&r2=363121&view=diff
==============================================================================
--- polly/trunk/include/polly/ScopBuilder.h (original)
+++ polly/trunk/include/polly/ScopBuilder.h Tue Jun 11 21:23:05 2019
@@ -375,6 +375,25 @@ class ScopBuilder {
/// ...
void verifyInvariantLoads();
+ /// Hoist invariant memory loads and check for required ones.
+ ///
+ /// We first identify "common" invariant loads, thus loads that are invariant
+ /// and can be hoisted. Then we check if all required invariant loads have
+ /// been identified as (common) invariant. A load is a required invariant load
+ /// if it was assumed to be invariant during SCoP detection, e.g., to assume
+ /// loop bounds to be affine or runtime alias checks to be placeable. In case
+ /// a required invariant load was not identified as (common) invariant we will
+ /// drop this SCoP. An example for both "common" as well as required invariant
+ /// loads is given below:
+ ///
+ /// for (int i = 1; i < *LB[0]; i++)
+ /// for (int j = 1; j < *LB[1]; j++)
+ /// A[i][j] += A[0][0] + (*V);
+ ///
+ /// Common inv. loads: V, A[0][0], LB[0], LB[1]
+ /// Required inv. loads: LB[0], LB[1], (V, if it may alias with A or LB)
+ void hoistInvariantLoads();
+
/// Collect loads which might form a reduction chain with @p StoreMA.
///
/// Check if the stored value for @p StoreMA is a binary operator with one or
Modified: polly/trunk/include/polly/ScopInfo.h
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/include/polly/ScopInfo.h?rev=363121&r1=363120&r2=363121&view=diff
==============================================================================
--- polly/trunk/include/polly/ScopInfo.h (original)
+++ polly/trunk/include/polly/ScopInfo.h Tue Jun 11 21:23:05 2019
@@ -2031,42 +2031,11 @@ private:
/// Check if the base ptr of @p MA is in the SCoP but not hoistable.
bool hasNonHoistableBasePtrInScop(MemoryAccess *MA, isl::union_map Writes);
- /// Return the context under which the access cannot be hoisted.
- ///
- /// @param Access The access to check.
- /// @param Writes The set of all memory writes in the scop.
- ///
- /// @return Return the context under which the access cannot be hoisted or a
- /// nullptr if it cannot be hoisted at all.
- isl::set getNonHoistableCtx(MemoryAccess *Access, isl::union_map Writes);
-
- /// Hoist invariant memory loads and check for required ones.
- ///
- /// We first identify "common" invariant loads, thus loads that are invariant
- /// and can be hoisted. Then we check if all required invariant loads have
- /// been identified as (common) invariant. A load is a required invariant load
- /// if it was assumed to be invariant during SCoP detection, e.g., to assume
- /// loop bounds to be affine or runtime alias checks to be placeable. In case
- /// a required invariant load was not identified as (common) invariant we will
- /// drop this SCoP. An example for both "common" as well as required invariant
- /// loads is given below:
- ///
- /// for (int i = 1; i < *LB[0]; i++)
- /// for (int j = 1; j < *LB[1]; j++)
- /// A[i][j] += A[0][0] + (*V);
- ///
- /// Common inv. loads: V, A[0][0], LB[0], LB[1]
- /// Required inv. loads: LB[0], LB[1], (V, if it may alias with A or LB)
- void hoistInvariantLoads();
-
/// Check if @p MA can always be hoisted without execution context.
bool canAlwaysBeHoisted(MemoryAccess *MA, bool StmtInvalidCtxIsEmpty,
bool MAInvalidCtxIsEmpty,
bool NonHoistableCtxIsEmpty);
- /// Add invariant loads listed in @p InvMAs with the domain of @p Stmt.
- void addInvariantLoads(ScopStmt &Stmt, InvariantAccessesTy &InvMAs);
-
/// Create an id for @p Param and store it in the ParameterIds map.
void createParameterId(const SCEV *Param);
@@ -2341,6 +2310,9 @@ public:
InvEquivClassVMap[LoadInst] = ClassRep;
}
+ /// Add invariant loads listed in @p InvMAs with the domain of @p Stmt.
+ void addInvariantLoads(ScopStmt &Stmt, InvariantAccessesTy &InvMAs);
+
/// Remove the metadata stored for @p Access.
void removeAccessData(MemoryAccess *Access);
@@ -2663,6 +2635,15 @@ public:
return MinMaxAliasGroups;
}
+ /// Return the context under which the access cannot be hoisted.
+ ///
+ /// @param Access The access to check.
+ /// @param Writes The set of all memory writes in the scop.
+ ///
+ /// @return Return the context under which the access cannot be hoisted or a
+ /// nullptr if it cannot be hoisted at all.
+ isl::set getNonHoistableCtx(MemoryAccess *Access, isl::union_map Writes);
+
/// Get an isl string representing the context.
std::string getContextStr() const;
Modified: polly/trunk/lib/Analysis/ScopBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopBuilder.cpp?rev=363121&r1=363120&r2=363121&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopBuilder.cpp (original)
+++ polly/trunk/lib/Analysis/ScopBuilder.cpp Tue Jun 11 21:23:05 2019
@@ -1320,6 +1320,25 @@ void ScopBuilder::verifyInvariantLoads()
}
}
+void ScopBuilder::hoistInvariantLoads() {
+ if (!PollyInvariantLoadHoisting)
+ return;
+
+ isl::union_map Writes = scop->getWrites();
+ for (ScopStmt &Stmt : *scop) {
+ InvariantAccessesTy InvariantAccesses;
+
+ for (MemoryAccess *Access : Stmt)
+ if (isl::set NHCtx = scop->getNonHoistableCtx(Access, Writes))
+ InvariantAccesses.push_back({Access, NHCtx});
+
+ // Transfer the memory access from the statement to the SCoP.
+ for (auto InvMA : InvariantAccesses)
+ Stmt.removeMemoryAccess(InvMA.MA);
+ scop->addInvariantLoads(Stmt, InvariantAccesses);
+ }
+}
+
void ScopBuilder::collectCandidateReductionLoads(
MemoryAccess *StoreMA, SmallVectorImpl<MemoryAccess *> &Loads) {
ScopStmt *Stmt = StoreMA->getStatement();
@@ -1670,7 +1689,7 @@ void ScopBuilder::buildScop(Region &R, A
return;
}
- scop->hoistInvariantLoads();
+ hoistInvariantLoads();
canonicalizeDynamicBasePtrs();
verifyInvariantLoads();
scop->simplifySCoP(true);
Modified: polly/trunk/lib/Analysis/ScopInfo.cpp
URL: http://llvm.org/viewvc/llvm-project/polly/trunk/lib/Analysis/ScopInfo.cpp?rev=363121&r1=363120&r2=363121&view=diff
==============================================================================
--- polly/trunk/lib/Analysis/ScopInfo.cpp (original)
+++ polly/trunk/lib/Analysis/ScopInfo.cpp Tue Jun 11 21:23:05 2019
@@ -3778,25 +3778,6 @@ isl::set Scop::getNonHoistableCtx(Memory
return WrittenCtx;
}
-void Scop::hoistInvariantLoads() {
- if (!PollyInvariantLoadHoisting)
- return;
-
- isl::union_map Writes = getWrites();
- for (ScopStmt &Stmt : *this) {
- InvariantAccessesTy InvariantAccesses;
-
- for (MemoryAccess *Access : Stmt)
- if (isl::set NHCtx = getNonHoistableCtx(Access, Writes))
- InvariantAccesses.push_back({Access, NHCtx});
-
- // Transfer the memory access from the statement to the SCoP.
- for (auto InvMA : InvariantAccesses)
- Stmt.removeMemoryAccess(InvMA.MA);
- addInvariantLoads(Stmt, InvariantAccesses);
- }
-}
-
ScopArrayInfo *Scop::getOrCreateScopArrayInfo(Value *BasePtr, Type *ElementType,
ArrayRef<const SCEV *> Sizes,
MemoryKind Kind,
More information about the llvm-commits
mailing list