[PATCH] D63043: [ELF][PPC] Simplify {read,write}FromHalf16
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 11 06:40:47 PDT 2019
MaskRay added a comment.
In D63043#1537967 <https://reviews.llvm.org/D63043#1537967>, @sfertile wrote:
> In D63043#1537919 <https://reviews.llvm.org/D63043#1537919>, @ruiu wrote:
>
> > Let me revert this change.
> >
> > Sean, feel free to revert a change if it broke buildbots like this. You don't have to go through a pre-commit code review for a revert change that fixes buildbots.
>
>
> Thanks. I tried reverting the breaking commit and a commit that built on top of it last week and was able to fix the PowerPC buildbot but broke all the X86 bots in the process. Unfortunately I don't have access to an X86 machine that can build llvm/lld right now so I backed out that change and ask @MaskRay to fix the bot.
>
> In D63043#1537942 <https://reviews.llvm.org/D63043#1537942>, @MaskRay wrote:
>
> > In D63043#1537919 <https://reviews.llvm.org/D63043#1537919>, @ruiu wrote:
> >
> > > Let me revert this change.
> > >
> > > Sean, feel free to revert a change if it broke buildbots like this. You don't have to go through a pre-commit code review for a revert change that fixes buildbots.
> >
> >
> > This revision is probably not the broken change. I'll check in a minute.
>
>
> Your right, I believe it was commits `729111cf1824159bb4dd331cab8a829eab30313f` and `f49f58527a6d8147524d8d6f2eb1feb70f856292` that need to be pulled out.
@sfertile Sorry but I can't find commit 729111cf1824159bb4dd331cab8a829eab30313f or f49f58527a6d8147524d8d6f2eb1feb70f856292 in either llvm/llvm-project (git monorepo) or llvm-mirror/lld (git multirepo). Do you have the revision numbers, e.g. r362867 (or rL362867 <https://reviews.llvm.org/rL362867> rLLD362867 <https://reviews.llvm.org/rLLD362867>; the latters give a clickable link on Phabricator)
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63043/new/
https://reviews.llvm.org/D63043
More information about the llvm-commits
mailing list