[PATCH] D63043: [ELF][PPC] Simplify {read,write}FromHalf16

Tue Jun 11 06:21:36 PDT 2019

MaskRay added a comment.

> Can you please address that before committing PPC64 changes like this. I don't understand why you would consider committing more PowerPC64 changes when the bot is in this state, rather then fixing it first.

@sfertile @anil9 I haven't received any email from ppc64le-lld-multistage-test since May 23. I am sorry I missed Anil's earlier email on rL361830 <https://reviews.llvm.org/rL361830>.

The old links on rL361830 <https://reviews.llvm.org/rL361830> are no longer available. From http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/4263/steps/build-stage2-unified-tree/logs/stdio

  ld.lld: error: relocation refers to a discarded section: .rodata._ZNK4llvm3MVT13getSizeInBitsEv
  >>> defined in utils/TableGen/CMakeFiles/llvm-tblgen.dir/CodeGenRegisters.cpp.o
  >>> referenced by CodeGenRegisters.cpp
  >>>               utils/TableGen/CMakeFiles/llvm-tblgen.dir/CodeGenRegisters.cpp.o:(.toc+0x0)

I don't think this revision is responsible for the breakage.

@sfertile I find you reverted rL361830 <https://reviews.llvm.org/rL361830> and D62840 <https://reviews.llvm.org/D62840> then restored them. I can't find the explanation why you did that. Sorry if I missed them.

AFAICT, D61583 <https://reviews.llvm.org/D61583> (relanded by rL361830 <https://reviews.llvm.org/rL361830>) caused some unhelpful errors that has been suppressed by D62840 <https://reviews.llvm.org/D62840>.

I'm still puzzled by the error on ppc64le because I think if my commit were bad, it should have caused other build bots to fail. May I ask you to run `LLD_REPRODUCE=/tmp/reproduce.tar clang++ ...` to get a reproduce tarball and upload it somewhere so that I can analyze it? Can you also check if ld.bfd or gold gives similar errors? (replace -fuse-ld=lld with -fuse-ld=bfd or -fuse-ld=gold)

@ruiu I don't think this commit is responsible for the build failure...

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63043/new/

https://reviews.llvm.org/D63043