[PATCH] D62995: [IntrinsicEmitter] Extend argument overloading with forward references.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: include/llvm/IR/Intrinsics.td:1185-1202
+def int_experimental_dummy_backward : Intrinsic<[llvm_anyvector_ty],
+                                                [llvm_anyvector_ty,
+                                                 LLVMVectorOfAnyPointersToElt<0>,
+                                                 LLVMVectorOfAnyPointersToElt<1>,
+                                                 LLVMVectorElementType<0>], []>;
+
+def int_experimental_dummy_forward : Intrinsic<[LLVMVectorOfAnyPointersToElt<0>],
----------------
sdesmalen wrote:
> arsenm wrote:
> > These should just go to a TableGen test file instead of defining a real intrinsic
> I agree these shouldn't be here, but I don't really know any other way to test the changes to `matchIntrinsicType` in `lib/IR/Function.cpp`. If we move these these to a separate TableGen test, it will only test the changes to TableGen.
Can you just add some cases with the real intrinsics after the use patch is committed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62995/new/

https://reviews.llvm.org/D62995