[PATCH] D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 10 06:52:30 PDT 2019
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, with one remaining suggestion.
================
Comment at: tools/llvm-readobj/llvm-readobj.h:26
void reportWarning(Twine Msg);
+ void warning(llvm::Error Err);
void error(std::error_code EC);
----------------
I'd call this function `warn`, not `warning` (warning is not a verb).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63074/new/
https://reviews.llvm.org/D63074
More information about the llvm-commits
mailing list