[PATCH] D63074: [llvm-readobj/llvm-readelf] - Don't fail to dump the object if .dynsym has broken sh_link field.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: tools/llvm-readobj/llvm-readobj.h:47
   }
+  template <class T> T unwrapOrWarn(Expected<T> EO) {
+    if (EO)
----------------
jhenderson wrote:
> Blank line before the function, please.
> 
> `EO` doesn't make sense as the variable name. What does it stand for?
This method was removed completely.

> Blank line before the function, please.

This probably was fine, it was consistent with other "unwrapOr*" helpers above. Sometimes in LLVM functions are grouped together without blank lines in between.

> EO doesn't make sense as the variable name. What does it stand for?

Copy paste.. Looking on the code above, initially it came from `ErrorOr`, but then was reused for `Expected<T>`




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63074/new/

https://reviews.llvm.org/D63074